avoid downloading dagger if requested version is already installed#187
avoid downloading dagger if requested version is already installed#187kpenfound merged 9 commits intodagger:mainfrom
Conversation
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
|
SGTM, but I think we could maybe avoid an error if the version if the right version of dagger is already installed? |
|
@jedevc thats the dilemma, right now it doesn't care about the version at all, only whether there is already a dagger binary in the path, and there is no error state. so you have:
my goal was to avoid error states, but we also don't want surprising behavior. The thinking is that if you have dagger pre-installed, you probably expect it to be there. If you want to override that with a specific version, there's a path to do that |
Signed-off-by: kpenfound <kyle@dagger.io>
|
I think the thing that confuses me with the table is that you can request IMO, if you set My suggestion would be to detect the version of the currently installed dagger, and check if it's the requested version (mildly annoying for commit builds off of main, but probably still doable). If it's the request version, skip, if not, then either, no particular preference:
I think that means that we wouldn't have a |
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Fixes #164
Check for an existing dagger install, and if its version matches the requested version, skip the installation step